Update jump-api pr #294
Merged
Update jump-api pr #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## jg/jumpapi #294 +/- ##
==============================================
- Coverage 89.10% 88.70% -0.41%
==============================================
Files 16 16
Lines 1992 2054 +62
==============================================
+ Hits 1775 1822 +47
- Misses 217 232 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joaquimg
commented
Jul 21, 2025
Comment on lines
+610
to
613
| # TODO check ci.value's | ||
| idx = model.cache.dual_mapping[ci.value] | ||
| return model.forw_grad_cache.dual_Δs[idx] | ||
| catch |
There was a problem hiding this comment.
@andrewrosemberg, this way of getting the map does not seem to match perfectly with the one below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.